Thanks, I love it! How hard do you think it would be to make it so that the popup window closes when pressing escape? it’s a behavior embedded in most other popup windows, it seems, and that I use a lot and thus am used to
That’s what it should be doing? I’m using the oncancel
event, maybe that has different behavior in some browsers. What browser are you using?
That’s Zen browser, which is a Firefox in disguise, on MacOS
Can’t replicate. Tried with newest Zen Browser on mac, works totally fine for me. Must be something with your setup.
I can not replicate this on recent Firefox on Linux. But according to the documentation the Escape
key is mapped to Stop Loading action by default in the Zen browser. Be there some way to unmap it, then try to unmap it (maybe there is the zen.keyboard.shortcuts.enabled
option to disable key mappings all at once - about:config).
Looks like this was caused by the Vimium addon I’m using. Disabling it made it so that I could use escape to close the search window. Sorry about the noise, thanks again for your help and the plugin also
A great addition to silverbullet. Thanks a lot for sharing!
I’ve now been using this for a while and… it’s pretty damn awesome. Completely puts the built-in search to shame (which, admittedly, wasn’t hard). This should a plug that everybody installs, although for licensing reasons we probably have to keep it outside of the main distribution for now.
Probably should feature this a bit more promimently on the website at some point.
Thanks again
Would it be possible to keep the plug code in a separate repo, but have the default installation just pull it in (so opt-out by removing a line in CONFIG)?
I don’t know if we wouldn’t get into muddy territory here, but what would be possible is for the default CONFIG to have the plug pre-listed, after which only a single Plugs: Update would pull it in.
@MrMugame this plugin is amazing (sorry it took so long for me to try this)! Does it auto-update its index as new things are created or do I need to trigger that manually?
This plugin looks supercool, and I’ll be definitely adding this to my instance. Thanks!
@zef I’m pretty sure every engineer has said this exact quote more times than would like to admit.
I’m sure I did a few times just this week. And it’s tuesday
It should. It listens to the same event SB internally listens to for its database.
We were planning to use SilverBullet as a ‘headless CMS’ for our websites, but came across a blocking issue: SilverBullet’s HTTP API has no ‘search’ function, which is pretty essential for any CMS.
I was wondering whether it would be possible for @MrMugame to extend the Silversearch plugin to perhaps also work on the server — either as a standalone command-line tool (so it would be available through the /.shell
API endpoint) — or even as a ‘server plugin’ that extends the HTTP API to expose a custom /.query
endpoint, as proposed in this Github feature request…
This isn’t really in the scope as it would pose a complete rewrite. There isn’t even a way to extend the SB server at the moment, so that would either need to be a fork or another server on top of SB. Tl;dr: A lot of work, for something (using SB as a CMS) that isn’t really a goal of SB.
I’ve implemented document indexing/searching into Silversearch. If you want to know how to use it and what documents you can index, take a look into the README, it should be updated.
If you want to try it, you have to use the edge build of Silverbullet, Silversearch and Silverbullet PDF with the following links
ghr:MrMugame/silversearch/edge
ghr:MrMugame/silverbullet-pdf/edge
Document indexing is now part of the newest release, so feel free to just update using Plugs: Update
. There should also be major performance improvements to the edge release.
Just a dumb question:
What does the “use tab to switch scope” is supposed to do?
If I press tab, I do not get any search results anymore.
Oh, not a dumb question. It only searches the page you are on instead of the whole space, so it switches the “scope of your search” … theoretically, I changed some stuff internally for the last release and broke it, I just fixed it now, so it should work again if you pull the newest release.
LOL Looks like I discovered that function just in time, when it was broken
However, now it does make sense and after updating it works as expected.
(And now I understand also, why the “insert link” disappears on scope change )
Thanks for clarification and the fix!