Draw.io Plug

Plugs
1

This plug enables you to edit Draw.io png or svg images attached to your page.

9 Likes
2

On Edge it’s working for someone?
Editor tab doesn’t open “Unregistered syscall space.readAttachment”

3

Yes, works for me with Edge version 134.0.3124.68 (and :edge version of SB :slight_smile: )

Nick

4

on SB edge (Package silverbullet ¡ GitHub daily updated) and last chrome version
It’s not working.
Many times, there are "Unregistered syscall xxx”. it’s probably an issue of caching and internal registering.

Have you any tips to solve " “Unregistered syscall" error?

5

The syscall readAttachment has been renamed to readDocument on Edge.
It looks like @LogeshG5 didn’t update that yet.

6

thanks @janssen-io . You are my support.
You are optimistic but day to day it’s hard to have a stable platform. ;(

7

Well, Edge isn’t meant to be stable. :wink: So I can’t blame Logesh either for not changing this yet.

8

Right. We assumed nobody is using this syscall so we could safely rename it.

9

No it’s not a problem of plugin maintainer.
Edge it’s a mix of fixes and breaking changes. There is a problem of organization.

To have a fix to solve a blocking issue, you have to switch to edge but edge introduces breaking changes…

That’s why many projects use git flow or alternative to have stability.

Bug fixes should be merged quickly on main branch and released.
And edge should be an unstable branch for next version with potentially breaking changes.

Moreover, if you introduce many break changes, we are going to lost plugin maintainer and users.

The vitality of the product should be compatible with stability.
Using semver with a git flow and short development cycle could be a solution.

What do you think?

10

The community is increasing. It will be difficult to know who is using which feature?

In the case of public method, to my mind, it’s important to proceed like that:

  • version+1: deprecated with warning
  • version +2: removed
    …

It’s less confortable for refactoring but better for maintainability.

Had you make a survey about seniority of users or lifespan of community plugins?

11

Hah no it wasn’t working. Edge is hard.

Did a quick fork for fixing this.

I doubt @LogeshG5 will accept my PR as it only works with SB:edge

12

To not break the plugin, both methods must be in the code on the same time.

Smooth migration.

But currently, it’s not possible.
We are in a deadlock like i described before.

13

Fixed as @Malys said “both methods must be in the code on the same time”.

Thanks @nickb for the pull request. I modified to keep both methods.

Let’s plan and prepare ahead to manage dependencies as the community is growing. Versioning documentation, plugins, etc.,?! :thinking:

Though this situation is an Edge case :wink:, I must say a new user would find it difficult to understand & resolve such issues.

1 Like
14

I’ll repeat: we didn’t realize this was used externally. In a bit I’ll push a fix to edge that brings back this syscall with the old name as an alias.

15

Pushed: Bring back readAttachment, listAttachments and readAttachmentMeta sys… · silverbulletmd/silverbullet@51bd3f3 · GitHub

Should be live on Edge in a few minutes.

Update: Should be live now. Please confirm.

1 Like
16

Hmm, this doesn’t seem to work now in either edge or v2, when I try to edit a diagram I get:

image
image1256×408 44.3 KB

Deleted images and containers, re-pulled, updated.

It looks like neither readDocument or readAttachment are available? Some sort of collision with @zef 's edit? I have tried my best but can’t work it out :slight_smile:

17

That was a regression that I thought I reverted. Have to check.

1 Like
18

Ok, it seems I only put this back on Edge for server mode, I just pushed it for sync mode as well. Also pushed back in the backwards compatible syscalls for v2.

1 Like
19

Thank you @zef, both v2 and edge working now.

1 Like