As stated in the title. Trying to access the conflict file would results in a notification saying “can’t create a file ending wtih file extension”.
Should be fairly easy to reproduce. Should I file an issue on GitHub first?
As stated in the title. Trying to access the conflict file would results in a notification saying “can’t create a file ending wtih file extension”.
Should be fairly easy to reproduce. Should I file an issue on GitHub first?
Yep, can confirm that. Probably my bad, because I have added support for extensions with numbers in them. I think github issue would be nice.
Cool, I’ll make the issue available later.
I can just revert this one or you want to something nicer @nvkv (nice to map you to a real name here btw )
This is not mine commit you are referencing, I’ll take a look a bit later what is happening indeed
Oh ok
So, here is WIP PR addressing this issue: WIP: Quick and dirty fix for the ".conflicted." pages navigation issue by nvkv · Pull Request #939 · silverbulletmd/silverbullet · GitHub
I’m a bit at lost how to fix up http_server.ts
part of the problem. With this fix applied you can Ctrl-K to conflicted page, but if you’ll refresh the page it will diligently return you a “404”.
Also there are 9 matches across 5 files for string \.[a-zA-Z0-9]
in a codebase, I think it’s worth to consolidate this check in one place. Not sure whether page_ref.ts
is the right one