Hi,
I am currently facing an issue in my 2 docker instances which are also configured as PWA, and in 2 different browsers (Chrome and Firefox).
When I have the instance opened, regardless if it is as a tab, or as a PWA, and I try to open person/Joe it does open that page in a new browser tab.
That means that when I am in PWA mode, I miss the page opened (Joe) as I normally have Silverbullet PWA instance opened in a different workspace than the rest of the apps.
If i open silverbullet as a browser tab, it just creates a new tab.
I can see the same behavior in Chrome and Firefox.
Does anyone see the same?
And if not, any idea how i could resolve this?
I cannot replicate this behavior. Does this happen when you navigate using the page picker or when clicking on links. And does it happen for all pages, or just pages in folders?
Thatās what I am trying to figure out.
I have an emoji assigned to the pages, trying to remove them to see if thatās the issue, but it is taking a long time for my instance to update the changes
Iāll force a new image right now and let you know. person/Joe was just an example. My pages are most of them real names, including surname. But i tested with pages without spaces and it was the same behavior.
Example, a real one that I have is this one, which opens in a new tab:
Oh wow, thatās very obscure, but indeed this is likely related to the recent introduction of custom editors,.
@MrMugame ā maybe something we can avoid? Itās not great to implicitly introduce new restrictions of attribute names like type. Itās not immediately obvious where this breaks, but I remember an additional type property being passed around, which is likely whatās clashing here.
@paletochen Iād expect that if you have twice the same key you either get a parse error, or the second overrides the other. Youād have to change it to list syntax, or use another term like kind for instance.
Yeah, Iām unsure of the top of my head where this happens, but Iām definitely gonna look into it today or tomorrow. Should definitely not happen tho
pageMeta overwrites the type causing the navigation to not know itās type. Is there a good reason to spread the metadata here? A quick solution would just be to reorder these so we overwrite the user provided metadata, thats not really nice tho
Maybe not good, but I think some of the code elsewhere is changing the rendering based on some specific attributes like aliases, tags etc. This has all become a bit messy over time, though. Maybe good to just pass on pageMeta without the spreading, and pull data from there in other places.